CitiWiki
: OldWakkaBugs
CitiWiki :: LogIn
Old Wakka bugs taken from WakkaBugtracker. For new bugs, please use the official bug tracking system at http://bugs.wakkawiki.com


Data: URI Links can Fail in Wakka


Data: URI links are neat ways to embed content (either whole pages or graphics/resources in web pages) in pages (note: IE doesn't understand them, but Gecko and Opera do). In WakkaWiki, image URI's are mangled by changing the encoding (see above link for examples). Ideally, WakkaWiki should not mangle these links; does anyone know why/a workaround?

--IanAndolina

Ooooo... that's cooool! Luckly I'm using the Gecko-based browser Mozilla.

--MingHong


Edit

I <http://www.ats20.de/wakka/index.php have the problem that with every "Edit" of a page there seems to be created a page
with an longer and then a page with a longer and a page with an even longer name, for example:
<See the link>

What did I make wrong? hiw@gmx.de


only 3attributes of action are used

I wrote an actionhandler for showing pictures and discovered that ony 3 attributes are used
i.e. {{img src="test.jpg" alt="test" border="0" align="left" width="10"}}
hadn't access to width

to fix it:
function Action($action, $forceLinkTracking = 0) { $action = trim($action); // stupid attributes check if (stristr($action, "=\"")) { // extract $action and $vars_temp ("raw" attributes) preg_match("/^([A-Za-z0-9]*)(.*)$/", $action, $matches); list(, $action, $vars_temp) = $matches; // match all attributes (key and value) preg_match_all("/([A-Za-z0-9]*)=\"(.*)\"/U", $vars_temp, $matches); // prepare an array for extract() to work with (in $this->IncludeBuffered()) if (is_array($matches)) { for ($a = 0; $a < count($matches[1]); $a++) { $vars[$matches[1][$a]] = $matches[2][$a]; } } }



Cross Site Scripting vulnerability

If you have a look near the top of the SandBox (altered at 2003-03-26 07:11:46), you can see that someone can post a link that contains scripting - which is a fairly nasty security hole :(.

I have a fix to this bug on LinkFormattingFix.  However, there is still a similar bug with double-double-quotes which I will put an example of in the SandBox as well.

note try changing line 101 of  formatters/wakka.php to return htmlspecialchars($matches[1]); to fix the double-double-quotes issue. However, this prevents exploiting the "bug" in order to insert graphics and other legitimate xhtml code. - JoeD


InterWiki Links Still Broken

0.1.2 now generates InterWiki links if the link is not a WikiWord (good), but the link goes nowhere if the search-term is not a WikiWord as well, e.g.:

Dictionary:Dilate - doesn't work.

Dictionary:DilatE - does work.

Also, how can one handle searches with spaces?

IanAndolina

I had a similar problem trying to make a link like http:/'/ca.wikipedia.com/wiki.cgi?Què_És_Un_Wiki, which didn't seem to work well in version 0.1.1. I solved it using escaped characters (http:/'/ca.wikipedia.com/wiki.cgi?Qu%E8_%E9s_Un_Wiki). You could maybe use %20 for spaces.
I have a list of escaped characters at my page.
--UilleAm



Problem with CSS, xml icon, revisions page (without mod_rewrite)

in the 0.1.2 version, the css not work with "rewrite_mode => 0".
the link to the .css file looks so: http://localhost/php/wakka/wakka.php?wakka=css/wakka.css by using "base_url"
but it should look like: http://localhost/php/wakka/css/wakka.css

StephanHertel

Note: The same problem also messes up the XML icons.. -- ArnarBirgisson
Note: Can it really be fixed with the following code? Presumably anyone who sets rewrite_mode to 0 does so because they cannot use rewrite rules. This bug also affects the ability to click on an old revision of a page. -- JoeD

Note: Can be fixed by using the following code -- SebastienHordeaux

RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^(.*)$ wakka.php?wakka=$1 [QSA,L]


Comment (JoeD): I believe this bug could essentially be eliminated if the links to graphics, css, and other internal links were rewritten as relative links (e.g., href="css/wakka.css") without any php parsing and a base href was added to the page header. If the base href is set properly, everything else will follow. Unfortunately I do not know php, but I've been playing around I have a solution, which I'm putting in RewriteMode.



Bug in the install.php file

in the File install.php at line 81 i mean there is a bug. The line called in my install.php:
mysql_query("insert into ".$config["table_prefix"]."pages set tag = '".$config["root_page"]."', body = '".mysql_escape_string("

i mean the end of the line is not korrekt?

StephanHertel


non-URI-Rewrite-mode problems

Name of Page at top of my Wiki doesn't Link to a TextSearch

The name of the page at the top links to a TextSearch of the page throughout the Wiki. Unfortunately my version of WakkaWiki puts a ? when a search puts an & - and when I click the link the wiki tells me  TextSearch?phrase=TextSearch page does not exist and if I want to create it. What do I need to do to get it to work?

ADDED 23Mar04: I add this exact problem with my wakkawiki when upgrading it with HTMLArea. I had copied and pasted various lines of text from a web page (for the upgrade) into edit.php and after doing so the switch of & to ? happened. I went through the lines of code again and again and everything looked right. Arggghhh. Anyhow, I had a "working" test wikki in another directory (without the code I had copied for htmlarea). I used "file compare" in Windows Commander and it highlighted two lines as being "different" even though they looked identical to me. I went through them a gazillion times to try and see differences but nothing. So, I copied and pasted the line of text from the "working" wiki to the non-working one. Still had the problem with replacing & with a ?...but still the lines were identified as being different by the file compare program. Finally, I copied and pasted a "block" on both sides of the apparently "different" text (which LOOKED exactly the same) from the working wiki to the non-working one and, tada, now the lines were not identified as being different and everything worked properly. The only thing I could think of was a hidden end-of-line character or something causing a problem.

--IanAndolina

Please try exchanging the formopen function in /wakka.php with this one. BUT do save the original file. This is not yet tested. Do it work?
%%(php)

function FormOpen($method = , $tag = , $formMethod = 'post', $name = )
{
$href = $this->href($method, $tag);

if (!$this->config['rewrite_mode'])
{
  $href = substr($href, 0, strpos($href, '?'));
/* FIXME: non-rewrite-mode should be generally fixed for hrefs with additional parameters (?) */
}

$result = '<form action="'.$href.'" method="'.strtolower($formMethod);
if ($name) $result .=